From 748830e60991b75cad9478221a10f2ab45617fa4 Mon Sep 17 00:00:00 2001
From: Marc Fokkert <marc.fokkert@powerhouse.nl>
Date: Wed, 10 Jul 2024 11:26:33 +0200
Subject: [PATCH] Fix null values

---
 .idea/misc.xml             |  2 +-
 .idea/vcs.xml              |  6 ++++++
 english_translations.ipynb | 36 ++++++++++++++++++++++++------------
 3 files changed, 31 insertions(+), 13 deletions(-)
 create mode 100644 .idea/vcs.xml

diff --git a/.idea/misc.xml b/.idea/misc.xml
index 20b24b9..730465f 100644
--- a/.idea/misc.xml
+++ b/.idea/misc.xml
@@ -3,7 +3,7 @@
   <component name="Black">
     <option name="sdkName" value="unity-client-translations" />
   </component>
-  <component name="ProjectRootManager" version="2" project-jdk-name="unity-client-translations" project-jdk-type="Python SDK" />
+  <component name="ProjectRootManager" version="2" project-jdk-name="dataspell" project-jdk-type="Python SDK" />
   <component name="PyCharmDSProjectLayout">
     <option name="id" value="JupyterRightHiddenStructureLayout" />
   </component>
diff --git a/.idea/vcs.xml b/.idea/vcs.xml
new file mode 100644
index 0000000..94a25f7
--- /dev/null
+++ b/.idea/vcs.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="VcsDirectoryMappings">
+    <mapping directory="$PROJECT_DIR$" vcs="Git" />
+  </component>
+</project>
\ No newline at end of file
diff --git a/english_translations.ipynb b/english_translations.ipynb
index 63f1c16..0a60b97 100644
--- a/english_translations.ipynb
+++ b/english_translations.ipynb
@@ -6,8 +6,8 @@
    "metadata": {
     "collapsed": true,
     "ExecuteTime": {
-     "end_time": "2024-07-09T14:56:22.945468Z",
-     "start_time": "2024-07-09T14:56:22.865984Z"
+     "end_time": "2024-07-10T09:18:02.468371Z",
+     "start_time": "2024-07-10T09:18:02.365001Z"
     }
    },
    "source": [
@@ -81,8 +81,10 @@
     "    for matching_nl_key in matching_nl_keys:\n",
     "        if matching_nl_key in old_en_translations:\n",
     "            return old_en_translations[matching_nl_key]\n",
-    "\n",
+    "        \n",
+    "    # could not find translation, return old value\n",
     "    skipped_keys.append(key)\n",
+    "    return new_en_translations[key]\n",
     "\n",
     "def translate_all_keys():\n",
     "    for key in new_en_translations:\n",
@@ -94,10 +96,10 @@
     "        f.write(json.dumps(new_en_json, indent=2, ensure_ascii=False))\n",
     "\n",
     "\n",
-    "old_nl_path = 'C:/Users/rescl/IdeaProjects/unity-client-ts/src/translations/unity-nl.json'\n",
-    "old_en_path = 'C:/Users/rescl/IdeaProjects/unity-client-ts/src/translations/unity-en.json'\n",
-    "new_en_path = 'C:/Users/rescl/IdeaProjects/unity-client-ts/src/i18n/messages.en.json'\n",
-    "new_nl_path = 'C:/Users/rescl/IdeaProjects/unity-client-ts/src/i18n/messages.nl.json'\n",
+    "old_nl_path = 'C:/Development/Projects/unity-client-ts/src/translations/unity-nl.json'\n",
+    "old_en_path = 'C:/Development/Projects/unity-client-ts/src/translations/unity-en.json'\n",
+    "new_en_path = 'C:/Development/Projects/unity-client-ts/src/i18n/messages.en.json'\n",
+    "new_nl_path = 'C:/Development/Projects/unity-client-ts/src/i18n/messages.nl.json'\n",
     "\n",
     "old_nl_translations = load_translations(old_nl_path)\n",
     "old_en_translations = load_translations(old_en_path)\n",
@@ -246,15 +248,22 @@
        " 'budgetAmountMutationInvoiceUnitDescription',\n",
        " 'budgetAmountMutationInvoiceUnitLabel',\n",
        " 'budgetAmountMutationInvoiceUnitNoResults',\n",
+       " 'budgetAmountMutationMessageAmountCel',\n",
        " 'budgetAmountMutationMessageAmountRound',\n",
        " 'budgetAmountMutationMessageAmountStartdate',\n",
        " 'budgetAmountMutationRelationLabel',\n",
        " 'budgetAmountMutationRelationName',\n",
        " 'budgetAmountMutationTitle',\n",
        " 'budgetAmountMutationValidateInputAmount',\n",
+       " 'budgetAmountMutationValidateNoValidHerhaalditemsError',\n",
+       " 'budgetAmountMutationValidatePossibleStartdatesError',\n",
+       " 'budgetAmountMutationValidateSaveBudgetMutationError',\n",
+       " 'budgetAmountMutationValidateSaveBudgetMutationSuccess',\n",
        " 'budgetAmountMutationVolumeTableBudgetAmount',\n",
        " 'budgetAmountMutationVolumeTableHeadCurrentAmount',\n",
        " 'budgetAmountMutationVolumeTableHeadNewAmount',\n",
+       " 'budgetPlanDeleteError',\n",
+       " 'budgetPlanDeleteSuccess',\n",
        " 'budgetPlanInvoiceUnitDescription',\n",
        " 'budgetPlanInvoiceUnitLabel',\n",
        " 'budgetPlanNoBudgetPlans',\n",
@@ -719,6 +728,9 @@
        " 'shared-contractTypeMarktsegmentArtikel1',\n",
        " 'shared-contractTypeMarktsegmentGrootverbruik',\n",
        " 'shared-contractTypeMarktsegmentKleinverbruik',\n",
+       " 'shared-errorAansluitingenFilterPostcodeWrongInput',\n",
+       " 'shared-errorBudgetplanWhenInvoiceExists',\n",
+       " 'shared-errorProcessingCarResult',\n",
        " 'telemetryConsumptionsConnection',\n",
        " 'telemetryConsumptionsConnectionAansluiting',\n",
        " 'telemetryConsumptionsConnectionAddress',\n",
@@ -802,25 +814,25 @@
        " 'wfmTasklistPopupTitleSub']"
       ]
      },
-     "execution_count": 10,
+     "execution_count": 1,
      "metadata": {},
      "output_type": "execute_result"
     }
    ],
-   "execution_count": 10
+   "execution_count": 1
   },
   {
    "metadata": {
     "ExecuteTime": {
-     "end_time": "2024-07-09T14:55:07.568995Z",
-     "start_time": "2024-07-09T14:55:07.565996Z"
+     "end_time": "2024-07-10T09:17:56.683655Z",
+     "start_time": "2024-07-10T09:17:56.665653Z"
     }
    },
    "cell_type": "code",
    "source": "",
    "id": "45916eb0ba9c02bf",
    "outputs": [],
-   "execution_count": 9
+   "execution_count": null
   },
   {
    "metadata": {},